From 16edafb4f96ec7accf2d797d10064364b5efdd5a Mon Sep 17 00:00:00 2001 From: Grégoire Duchêne Date: Sat, 3 Dec 2022 21:37:43 +0000 Subject: Remove ‘value’ argument from Flag{,Slice}Var MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It’s basically redundant since a pointer to the value is already provided; callers can just set a default value there. --- flag_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'flag_test.go') diff --git a/flag_test.go b/flag_test.go index 1f36b63..91c6caa 100644 --- a/flag_test.go +++ b/flag_test.go @@ -25,8 +25,8 @@ func TestFlagVar(s *testing.T) { t := core.T{T: s} fs := flag.NewFlagSet("", flag.PanicOnError) - var fl int - core.FlagVar(fs, &fl, "test", 42, "", strconv.Atoi) + fl := 42 + core.FlagVar(fs, &fl, "test", "", strconv.Atoi) t.AssertEqual(42, fl) t.AssertErrorIs(nil, fs.Parse([]string{"-test=84"})) t.AssertEqual(84, fl) @@ -46,8 +46,8 @@ func TestFlagSliceVar(s *testing.T) { t := core.T{T: s} fs := flag.NewFlagSet("", flag.PanicOnError) - var fl []int - core.FlagSliceVar(fs, &fl, "test", []int{42}, "", strconv.Atoi, ",") + fl := []int{42} + core.FlagSliceVar(fs, &fl, "test", "", strconv.Atoi, ",") t.AssertEqual([]int{42}, fl) t.AssertErrorIs(nil, fs.Parse([]string{"-test=1", "-test=2", "-test=42,84"})) t.AssertEqual([]int{1, 2, 42, 84}, fl) -- cgit v1.2.3-70-g09d2